netdev - Re: [PATCH v2 net] fou, fou6: do not assume linear skbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190111153908.6ac4df34@redhat.com>
Date:   Fri, 11 Jan 2019 15:39:08 +0100
From:   Stefano Brivio <sbrivio@...hat.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        syzbot <syzkaller@...glegroups.com>,
        Sabrina Dubroca <sd@...asysnail.net>
Subject: Re: [PATCH v2 net] fou, fou6: do not assume linear skbs

On Fri, 11 Jan 2019 06:27:35 -0800
Eric Dumazet <edumazet@...gle.com> wrote:

> Both gue_err() and gue6_err() incorrectly assume
> linear skbs. Fix them to use pskb_may_pull().
> 
> BUG: KMSAN: uninit-value in gue6_err+0x475/0xc40 net/ipv6/fou6.c:101
> CPU: 0 PID: 18083 Comm: syz-executor1 Not tainted 5.0.0-rc1+ #7
>
> [...]
>
> Fixes: b8a51b38e4d4 ("fou, fou6: ICMP error handlers for FoU and GUE")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>
> Cc: Stefano Brivio <sbrivio@...hat.com>
> Cc: Sabrina Dubroca <sd@...asysnail.net>

Acked-by: Stefano Brivio <sbrivio@...hat.com>