netdev - Re: [PATCH net-next v4] Documentation: networking: Clarify switchdev devices behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Jan 2019 15:53:08 +0000
From:   Ido Schimmel <idosch@...lanox.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     Florian Fainelli <f.fainelli@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "vivien.didelot@...il.com" <vivien.didelot@...il.com>,
        "cphealy@...il.com" <cphealy@...il.com>,
        Jiri Pirko <jiri@...lanox.com>,
        "bridge@...ts.linux-foundation.org" 
        <bridge@...ts.linux-foundation.org>,
        "nikolay@...ulusnetworks.com" <nikolay@...ulusnetworks.com>,
        "roopa@...ulusnetworks.com" <roopa@...ulusnetworks.com>,
        "rdunlap@...radead.org" <rdunlap@...radead.org>,
        "ilias.apalodimas@...aro.org" <ilias.apalodimas@...aro.org>,
        "ivan.khoronzhuk@...aro.org" <ivan.khoronzhuk@...aro.org>
Subject: Re: [PATCH net-next v4] Documentation: networking: Clarify switchdev
 devices behavior

On Fri, Jan 11, 2019 at 04:43:31PM +0100, Andrew Lunn wrote:
> > > +IGMP snooping
> > > +~~~~~~~~~~~~~
> > > +
> > > +The Linux bridge allows the configuration of IGMP snooping (compile and run
> > > +time) which must be observed by the underlying switchdev network device/hardware
> > > +in the following way:
> > > +
> > > +- when IGMP snooping is turned off, multicast traffic must be flooded to all
> > > +  switch ports within the same broadcast domain. The CPU/management port
> > > +  should ideally not be flooded and continue to learn multicast traffic through
> > > +  the network stack notifications. If the hardware is not capable of doing that
> > > +  then the CPU/management port must also be flooded and multicast filtering
> > > +  happens in software.
> > > +
> > > +- when IGMP snooping is turned on, multicast traffic must selectively flow
> > > +  to the appropriate network ports (including CPU/management port) and not flood
> > > +  the switch.
> > > +
> > > +Note: reserved multicast addresses (e.g.: BPDUs) as well as Local Network
> > > +Control block (224.0.0.0 - 224.0.0.255) do not require IGMP and should always
> > > +be flooded.
> > 
> > I'm not sure that these paragraphs are actually needed. You're basically
> > describing RFC 4541 on which the IGMP snooping functionality in the
> > Linux bridge is based on.
> 
> Hi Ido
> 
> My experience talking with people is that IGMP snooping is a bit
> mystical and not well understood. I would not be surprised if
> community driver writers, as opposed to vendor driver writers, don't
> actually know how snooping works. So i find having some hints is good.

Can we at least mention this RFC is the doc? It's very well written IMO