netdev - Re: [PATCH net] bridge: Fix ethernet header pointer before check skb forwardable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190112145449.GB16179@lunn.ch>
Date:   Sat, 12 Jan 2019 15:54:49 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     wangyunjian <wangyunjian@...wei.com>
Cc:     netdev@...r.kernel.org, xudingke@...wei.com
Subject: Re: [PATCH net] bridge: Fix ethernet header pointer before check skb
 forwardable

On Sat, Jan 12, 2019 at 06:28:27PM +0800, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian@...wei.com>
> 
> The skb header should be set to ethernet header before using
> is_skb_forwardable(including dev->hard_header_len length).

Hi Yunjian

I don't see any recent changes in this code. Do you know why this is
needed now, yet it seemed to work before? Do you have a fixes: tag for
where it broke?

Thanks
	Andrew