netdev - Re: [PATCH 1/3] net: introduce SO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 14 Jan 2019 04:09:06 +0800
From:   kbuild test robot <lkp@...el.com>
To:     David Herrmann <dh.herrmann@...il.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org, davem@...emloft.net,
        teg@...m.no, David Herrmann <dh.herrmann@...il.com>
Subject: Re: [PATCH 1/3] net: introduce SO_BINDTOIF sockopt

Hi David,

I love your patch! Yet something to improve:

[auto build test ERROR on net/master]
[also build test ERROR on v5.0-rc1 next-20190111]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/David-Herrmann/net-introduce-SO_BINDTOIF-sockopt/20190111-124603
config: sparc-sparc64_defconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=sparc 

All errors (new ones prefixed by >>):

   net/core/sock.c: In function 'sock_getsockopt':
>> net/core/sock.c:1424:2: error: duplicate case value
     case SO_BINDTOIF:
     ^~~~
   net/core/sock.c:1258:2: note: previously used here
     case SO_PEERCRED:
     ^~~~

vim +1424 net/core/sock.c

  1403	
  1404		case SO_COOKIE:
  1405			lv = sizeof(u64);
  1406			if (len < lv)
  1407				return -EINVAL;
  1408			v.val64 = sock_gen_cookie(sk);
  1409			break;
  1410	
  1411		case SO_ZEROCOPY:
  1412			v.val = sock_flag(sk, SOCK_ZEROCOPY);
  1413			break;
  1414	
  1415		case SO_TXTIME:
  1416			lv = sizeof(v.txtime);
  1417			v.txtime.clockid = sk->sk_clockid;
  1418			v.txtime.flags |= sk->sk_txtime_deadline_mode ?
  1419					  SOF_TXTIME_DEADLINE_MODE : 0;
  1420			v.txtime.flags |= sk->sk_txtime_report_errors ?
  1421					  SOF_TXTIME_REPORT_ERRORS : 0;
  1422			break;
  1423	
> 1424		case SO_BINDTOIF:
  1425			v.val = sk->sk_bound_dev_if;
  1426			break;
  1427	
  1428		default:
  1429			/* We implement the SO_SNDLOWAT etc to not be settable
  1430			 * (1003.1g 7).
  1431			 */
  1432			return -ENOPROTOOPT;
  1433		}
  1434	
  1435		if (len > lv)
  1436			len = lv;
  1437		if (copy_to_user(optval, &v, len))
  1438			return -EFAULT;
  1439	lenout:
  1440		if (put_user(len, optlen))
  1441			return -EFAULT;
  1442		return 0;
  1443	}
  1444	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (17886 bytes)