netdev - Re: [PATCH RFC 1/3] net: Prepare GSO return values for fraglist GSO.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190114125304.GG3581@gauss3.secunet.de>
Date:   Mon, 14 Jan 2019 13:53:04 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Paolo Abeni <pabeni@...hat.com>
CC:     <netdev@...r.kernel.org>, Willem de Bruijn <willemb@...gle.com>,
        "Jason A. Donenfeld" <Jason@...c4.com>
Subject: Re: [PATCH RFC 1/3] net: Prepare GSO return values for fraglist GSO.

On Tue, Jan 08, 2019 at 02:53:52PM +0100, Paolo Abeni wrote:
> On Fri, 2018-12-21 at 08:53 +0100, Steffen Klassert wrote:
> > On fraglist GSO, we don't need to clone the original
> > skb. So we don't have anything to return to free.
> > Prepare GSO that it frees the original skb only
> > if the return pointer really changed. Fraglist
> > GSO frees the original skb itself on error and
> > returns -EREMOTE in this case.
> 
> I think it would be nicer preseving the same sematic with gro list, so
> that we don't have to add this special handling.
> 
> e.g. calling skb_get(skb) in skb_segment_list() when successful, would
> avoid the special handling for the no error case (at the cost of 2
> atomic ops per gso_list packet)

That's a good idea, I'll do this in the next version of the patchset.