netdev - Re: [PATCH iproute2] ip route: get: only set RTM_F_LOOKUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24a5672e-a574-dfdc-3482-e86056e22939@gmail.com>
Date:   Mon, 14 Jan 2019 09:29:51 -0700
From:   David Ahern <dsahern@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com
Subject: Re: [PATCH iproute2] ip route: get: only set RTM_F_LOOKUP_TABLE flag
 for IPv4

On 1/14/19 9:05 AM, Stephen Hemminger wrote:
> On Sat, 12 Jan 2019 12:54:06 -0800
> Jakub Kicinski <jakub.kicinski@...ronome.com> wrote:
> 
>> Kernel ignores the RTM_F_LOOKUP_TABLE flag for all families
>> but IPv4.  Don't set it, otherwise it may fall foul of
>> strict checking policies.
>>
>> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> 
> Doing the right thing is a good idea, but really I can't see
> the point of doing this. The kernel will always have to accept
> requests from older versions of iproute2 (it can never be stricter)
> because of ABI compatibility. So unless you can make a stronger
> case for this; no not applying it.
> 

iproute2 is often used as a reference model for features. Making
iproute2 correct is the right thing to do regardless of whether what the
kernel accepts.

Current master branch is the first iproute2 to use the strict checking,
and its first release with strict checking should have as many of these
little one offs as possible fixed.