netdev - Re: [Patch net] net_sched: refetch skb protocol for each filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpWxPbWdM8hz7OEqKE+4eCd7_R5uJvsab6k+oQqi_11-2w@mail.gmail.com>
Date:   Tue, 15 Jan 2019 09:57:49 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Jamal Hadi Salim <jhs@...atatu.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Martin Olsson <martin.olsson+netdev@...torsecurity.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Lucas Bates <lucasb@...atatu.com>
Subject: Re: [Patch net] net_sched: refetch skb protocol for each filter

On Tue, Jan 15, 2019 at 8:21 AM Jamal Hadi Salim <jhs@...atatu.com> wrote:
>
> On 2019-01-15 10:59 a.m., Jamal Hadi Salim wrote:
> > On 2019-01-13 4:08 p.m., Cong Wang wrote:
> >> On Sat, Jan 12, 2019 at 7:41 AM Jamal Hadi Salim <jhs@...atatu.com>
>
> [..]
> > I agree with your rationale.
> > Lets have Lucas give this a run and we can move
> > forward.
>
> And as an addendum - Martin corrected me, he did have a "continue"
> after the vlan pop (not illegal to do). So i think your patch
> is fine; lets not mix it up with vlan not correctly matching
> (two separate issues).
>
> Lets have Lucas create the tdc test, then add my Ack.

As I said, this case is a bit hard to add to tdc test, because:

1. It requires a vlan device on top. This is not hard to do, but still
needs some extra work.

2. It requires a run-time test, like ping. This is different from other
test cases which test setup-time config's. This is a bit hard because
we have to parse tc filter stats to learn if some filter is hit or not.

I am sure Lucas can do it, just it is not as easy as other cases.

Thanks.