[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190115134242.0d9c01b4@cakuba.netronome.com>
Date: Tue, 15 Jan 2019 13:42:42 -0800
From: Jakub Kicinski <jakub.kicinski@...ronome.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Jiri Pirko <jiri@...nulli.us>, davem@...emloft.net,
netdev@...r.kernel.org, oss-drivers@...ronome.com
Subject: Re: [RFC net-next 1/6] devlink: add device information API
On Tue, 15 Jan 2019 21:00:12 +0100, Andrew Lunn wrote:
> > Ack, will do. IMHO it's a bit of an overkill, one could "safely
> > assume" serial number won't be longer than 32 bytes.. :) But no
> > problem, will do!
>
> A git hash is 40 bytes.
It's 20 bytes, this is in binary form. Plus serial numbers are unique
ID of the device, not sure how hash would work there ;)
But I take your point, I'll redo this bit! :)
Powered by blists - more mailing lists