netdev - Re: [PATCH net] net: phy: fix too strict check in phy_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190115.134553.201929364823715675.davem@davemloft.net>
Date:   Tue, 15 Jan 2019 13:45:53 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org,
        chris@...is-wilson.co.uk
Subject: Re: [PATCH net] net: phy: fix too strict check in phy_start_aneg

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Wed, 9 Jan 2019 20:34:56 +0100

> When adding checks to detect wrong usage of the phylib API we added
> a check to phy_start_aneg() which is too strict. If the phylib
> state machine is in state PHY_HALTED we should allow reconfiguring
> and restarting aneg, and just don't touch the state.
> 
> Fixes: 2b3e88ea6528 ("net: phy: improve phy state checking")
> Reported-by: Chris Wilson <chris@...is-wilson.co.uk>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied.