netdev - Re: [PATCH bpf v3] tools/bpf: properly account for libbfd variations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <83bb6cb9-a692-1c93-c863-dd4cae28d058@iogearbox.net>
Date:   Wed, 16 Jan 2019 00:55:16 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Stanislav Fomichev <sdf@...gle.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, ast@...nel.org, jakub.kicinski@...ronome.com,
        quentin.monnet@...ronome.com
Subject: Re: [PATCH bpf v3] tools/bpf: properly account for libbfd variations

On 01/15/2019 11:03 PM, Stanislav Fomichev wrote:
> On some platforms, in order to link against libbfd, we need to
> link against liberty and even possibly libz. Account for that
> in the bpftool Makefile. We now have proper feature detection
> for each case, so handle each one separately.
> 
> See recent commit 14541b1e7e72 ("perf build: Don't unconditionally link the
> libbfd feature test to -liberty and -lz") where I fixed feature
> detection.
> 
> v2 (addressed Jakub's nits):
>   * better syntax for 'else ifeq'
>   * no space between ifeq args
> v3:
>   * use LIBS, not EXTLIBS for -DHAVE_LIBBFD_SUPPORT
> 
> Fixes: 29a9c10e4110 ("bpftool: make libbfd optional")
> Signed-off-by: Stanislav Fomichev <sdf@...gle.com>

Applied, thanks!