netdev - Re: [RFC iproute2-next] devlink: add info subcommand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190115140729.GF2290@nanopsycho>
Date:   Tue, 15 Jan 2019 15:07:29 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Jakub Kicinski <jakub.kicinski@...ronome.com>, davem@...emloft.net,
        netdev@...r.kernel.org, oss-drivers@...ronome.com
Subject: Re: [RFC iproute2-next] devlink: add info subcommand

Tue, Jan 15, 2019 at 03:00:46PM CET, andrew@...n.ch wrote:
>On Tue, Jan 15, 2019 at 09:20:11AM +0100, Jiri Pirko wrote:
>> [...]
>> 
>> > static void help(void)
>> > {
>> > 	pr_err("Usage: devlink [ OPTIONS ] OBJECT { COMMAND | help }\n"
>> > 	       "       devlink [ -f[orce] ] -b[atch] filename\n"
>> >-	       "where  OBJECT := { dev | port | sb | monitor | dpipe | resource | region }\n"
>> >+	       "where  OBJECT := { dev | port | sb | monitor | dpipe | resource | region | info }\n"
>> 
>> I think that "info" should be nested under "dev". It is related to dev.
>> Maybe it even does not have to be a separate command and can be a nested
>> attribute to existing DEVLINK_CMD_GET cmd.
>
>Hi Jiri
>
>Not that i agree devlink is the right place for this, but i think it

Where else to put it?

>probably needs to be nested both under dev and port. I could have a
>line card implementing a port which has version information, as well
>as version information for the backplane which would be under dev.

Okay. Sounds good to me.


>
>   Andrew