netdev - Re: [Patch net] net_sched: refetch skb protocol for each filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cb8f01ce-e5eb-311d-5fd4-29342a5471f4@mojatatu.com>
Date:   Wed, 16 Jan 2019 09:02:07 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Martin Olsson <martin.olsson+netdev@...torsecurity.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Lucas Bates <lucasb@...atatu.com>
Subject: Re: [Patch net] net_sched: refetch skb protocol for each filter

On 2019-01-15 12:57 p.m., Cong Wang wrote:
> On Tue, Jan 15, 2019 at 8:21 AM Jamal Hadi Salim <jhs@...atatu.com> wrote:
>>

>>
>> Lets have Lucas create the tdc test, then add my Ack.
> 
> As I said, this case is a bit hard to add to tdc test, because:
> 
> 1. It requires a vlan device on top. This is not hard to do, but still
> needs some extra work.
> 
> 2. It requires a run-time test, like ping. This is different from other
> test cases which test setup-time config's. This is a bit hard because
> we have to parse tc filter stats to learn if some filter is hit or not.
> 
> I am sure Lucas can do it, just it is not as easy as other cases.

Lucas has confirmed to me he manually tested it (I just Acked).
Yes, it is tricky to add this test case but he will spend time
to build the infrastructure and submit this test as first user.
We discussed and the stats scrapping is doable with python and
the -j tc option.

cheers,
jamal