netdev - Re: [RFC PATCH 1/5] net: lorawan: Refine the coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC=mGzh9ArNPYF0yALggPTMRdU1QQ7Vg7m9fKf5C1Rh01xv2Qw@mail.gmail.com>
Date:   Thu, 17 Jan 2019 00:06:14 +0800
From:   Jian-Hong Pan <starnight@...cu.edu.tw>
To:     Andreas Färber <afaerber@...e.de>
Cc:     Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org,
        linux-lpwan@...ts.infradead.org,
        Ben Whitten <ben.whitten@...rdtech.com>,
        "linux-kernel@...r.kernel.org>," <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 1/5] net: lorawan: Refine the coding style

Andreas Färber <afaerber@...e.de> 於 2019年1月16日 週三 下午11:07寫道：
>
> Am 16.01.19 um 15:33 schrieb Jiri Pirko:
> > Wed, Jan 16, 2019 at 03:24:54PM CET, starnight@...cu.edu.tw wrote:
> >> Signed-off-by: Jian-Hong Pan <starnight@...cu.edu.tw>
> >> ---
> >
> > Patches like this are in general frowned upon. Do one change in one
> > patch. Put some patch description.
>
> This patch simply shouldn't have gone to netdev and LKML, as it is a
> fixup against a non-stable tree (missing "lora-next"). Once squashed, it
> doesn't matter whether it once had a verbose explanation or not. And I
> prefer to not mix style and functional changes.

Uh!  I see.

Regards,
Jian-Hong Pan

> I simply was too impatient to wait for more respins before being able to
> base work on it. ;)