netdev - Re: [PATCH net 1/2] udp: add missing rehash callback to udplite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+ttTe8R2NxWFfAQR+fsOodn0d7Mw09=LN4oNKjp=9RhA@mail.gmail.com>
Date:   Wed, 16 Jan 2019 08:33:35 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     Alexey Kodanev <alexey.kodanev@...cle.com>
Cc:     netdev <netdev@...r.kernel.org>, Peter Oskolkov <posk@...gle.com>,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH net 1/2] udp: add missing rehash callback to udplite

On Wed, Jan 16, 2019 at 8:08 AM Alexey Kodanev
<alexey.kodanev@...cle.com> wrote:
>
> After commit 4cdeeee9252a ("net: udp: prefer listeners bound to an
> address"), UDP-Lite only works when specifying a local address for
> the sockets.
>
> This is related to the problem addressed in the commit 719f835853a9
> ("udp: add rehash on connect()"). Moreover, __udp4_lib_lookup() now
> looks for a socket immediately in the secondary hash table.
>
> The issue was found with LTP/network tests (UDP-Lite test-cases).
>
> Signed-off-by: Alexey Kodanev <alexey.kodanev@...cle.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Note that we prefer having the Fixes: tag to help automation.

Thanks !