netdev - Re: [PATCH net] net: ip6_gre: use erspan key field for tunnel lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190116164003.GC2454@localhost.localdomain>
Date:   Wed, 16 Jan 2019 17:40:04 +0100
From:   Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
To:     Davide Caratti <dcaratti@...hat.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, u9012063@...il.com
Subject: Re: [PATCH net] net: ip6_gre: use erspan key field for tunnel lookup

> 
> hi Lorenzo,
> 
> are we sure that 'ershdr' is in the linear part of skb? if not, we might
> need a call to pskb_may_pull() here.

Hi Davide,

thx for the review. I agree, I think we should check erspan header with
pskb_may_pull in gre_parse_header. In this way we can remove the check
in ip6erspan_rcv() and erspan_rcv(). I will fix in v2

Does '((*(u8 *)options & 0xF0) != 0x40)' have the same issue?

Regards,
Lorenzo

> 
> thanks!
> -- 
> davide
> 
> 
>