[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190116211716.o6rkxtajphryj7rk@kafai-mbp.dhcp.thefacebook.com>
Date: Wed, 16 Jan 2019 21:17:17 +0000
From: Martin Lau <kafai@...com>
To: Peter Oskolkov <posk@...gle.com>
CC: Alexei Starovoitov <ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
Peter Oskolkov <posk.devel@...il.com>
Subject: Re: [PATCH bpf-next v2] bpf: fix a (false) compiler warning
On Wed, Jan 16, 2019 at 10:43:01AM -0800, Peter Oskolkov wrote:
> An older GCC compiler complains:
>
> kernel/bpf/verifier.c: In function 'bpf_check':
> kernel/bpf/verifier.c:4***:13: error: 'prev_offset' may be used uninitialized
> in this function [-Werror=maybe-uninitialized]
> } else if (krecord[i].insn_offset <= prev_offset) {
> ^
> kernel/bpf/verifier.c:4***:38: note: 'prev_offset' was declared here
> u32 i, nfuncs, urec_size, min_size, prev_offset;
>
> Although the compiler is wrong here, the patch makes sure
> that prev_offset is always initialized, just to silence the warning.
>
> v2: fix a spelling error in the commit message.
>
> Signed-off-by: Peter Oskolkov <posk@...gle.com>
Acked-by: Martin KaFai Lau <kafai@...com>
Powered by blists - more mailing lists