netdev - Re: [PATCH net-next] virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190116.153158.1210819126964530944.davem@davemloft.net>
Date:   Wed, 16 Jan 2019 15:31:58 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     mst@...hat.com
Cc:     linux-kernel@...r.kernel.org, jasowang@...hat.com,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] virtio_net: bulk free tx skbs

From: "Michael S. Tsirkin" <mst@...hat.com>
Date: Mon, 14 Jan 2019 20:34:26 -0500

> Use napi_consume_skb() to get bulk free.  Note that napi_consume_skb is
> safe to call in a non-napi context as long as the napi_budget flag is
> correct.
> 
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> ---
> 
> My perf testing setup is down but it works fine on my devel box and
> should be fairly uncontroversial.

It would be uncontroversial if it compiled.

drivers/net/virtio_net.c: In function ‘free_old_xmit_skbs’:
drivers/net/virtio_net.c:1346:25: error: ‘use_napi’ undeclared (first use in this function); did you mean ‘used_math’?
   napi_consume_skb(skb, use_napi);
                         ^~~~~~~~
                         used_math
drivers/net/virtio_net.c:1346:25: note: each undeclared identifier is reported only once for each function it appears in