netdev - Re: [PATCH net v2] ipv6: route: place a warning with duplicated string with correct extack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b02168e-c41b-7dc4-61fd-5cbc4492e92d@gmail.com>
Date:   Tue, 15 Jan 2019 20:54:00 -0700
From:   David Ahern <dsahern@...il.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com, joe@...ches.com
Subject: Re: [PATCH net v2] ipv6: route: place a warning with duplicated
 string with correct extack

On 1/14/19 11:52 AM, Jakub Kicinski wrote:
> "IPv6: " prefix is already added by pr_fmt, no need to include
> it again in the pr_warn() format.  The message predates extack
> support, we can replace the whole thing with an extack message.
> 
> Suggested-by: David Ahern <dsahern@...il.com>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> ---
>  net/ipv6/route.c | 14 ++------------
>  1 file changed, 2 insertions(+), 12 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...il.com>