netdev - Re: [PATCH net] net/sched: act_tunnel_key: fix memory leak in case of action replace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190115.214007.54305144538440337.davem@davemloft.net>
Date:   Tue, 15 Jan 2019 21:40:07 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     dcaratti@...hat.com
Cc:     jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        netdev@...r.kernel.org, amir@...ai.me
Subject: Re: [PATCH net] net/sched: act_tunnel_key: fix memory leak in case
 of action replace

From: Davide Caratti <dcaratti@...hat.com>
Date: Thu, 10 Jan 2019 20:21:02 +0100

> running the following TDC test cases:
> 
>  7afc - Replace tunnel_key set action with all parameters
>  364d - Replace tunnel_key set action with all parameters and cookie
> 
> it's possible to trigger kmemleak warnings like:
 ...
> when the tunnel_key action is replaced, the kernel forgets to release the
> dst metadata: ensure they are released by tunnel_key_init(), the same way
> it's done in tunnel_key_release().
> 
> Fixes: d0f6dd8a914f4 ("net/sched: Introduce act_tunnel_key")
> Signed-off-by: Davide Caratti <dcaratti@...hat.com>

Applied and queued up for -stable.