netdev - Re: [PATCH net] net: phy: marvell: Fix deadlock from wrong locking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 15 Jan 2019 21:53:43 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     f.fainelli@...il.com, hkallweit1@...il.com, netdev@...r.kernel.org,
        ake.rehnman@...il.com
Subject: Re: [PATCH net] net: phy: marvell: Fix deadlock from wrong locking

From: Andrew Lunn <andrew@...n.ch>
Date: Fri, 11 Jan 2019 00:15:21 +0100

> m88e1318_set_wol() takes the lock as part of phy_select_page(). Don't
> take the lock again with phy_read(), use the unlocked __phy_read().
> 
> Fixes: 424ca4c55121 ("net: phy: marvell: fix paged access races")
> Reported-by: Åke Rehnman <ake.rehnman@...il.com>
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Applied and queued up for -stable.