netdev - Re: [PATCH bpf-next 8/9] libbpf: introduce bpf_map_lookup_elem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190116062811.3e3ein2i5b4rkdio@ast-mbp>
Date:   Tue, 15 Jan 2019 22:28:12 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Yonghong Song <yhs@...com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "jakub.kicinski@...ronome.com" <jakub.kicinski@...ronome.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH bpf-next 8/9] libbpf: introduce
 bpf_map_lookup_elem_flags()

On Wed, Jan 16, 2019 at 06:18:30AM +0000, Yonghong Song wrote:
> 
> 
> On 1/15/19 9:08 PM, Alexei Starovoitov wrote:
> > Introduce
> > int bpf_map_lookup_elem_flags(int fd, const void *key, void *value, __u64 flags)
> > helper to lookup array/hash/cgroup_local_storage elements with BPF_F_LOCK flag.
> > 
> > Signed-off-by: Alexei Starovoitov <ast@...nel.org>
> > ---
> >   tools/lib/bpf/bpf.c      |  13 ++
> >   tools/lib/bpf/bpf.h      |   2 +
> >   tools/lib/bpf/libbpf.map |   4 +
> >   tools/lib/bpf/tags       | 254 +++++++++++++++++++++++++++++++++++++++
> 
> I think this tools/lib/bpf/tags is not needed and accidentally slipped 
> in due to cscope?

Oops.
Funny how checkpatch.pl commented about it:
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69:
new file mode 100644

it didn't mention the file by name, so I ignored that warning.

Please continue reviewing. I will respin.