netdev - Re: [PATCH bpf-next v4 1/9] tools: bpftool: add basic probe capability, probe syscall availability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d2268000-da45-1fbf-9672-3abcdda5351a@iogearbox.net>
Date:   Thu, 17 Jan 2019 11:11:03 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Quentin Monnet <quentin.monnet@...ronome.com>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     Alexei Starovoitov <ast@...nel.org>, netdev@...r.kernel.org,
        oss-drivers@...ronome.com,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Stanislav Fomichev <sdf@...gle.com>
Subject: Re: [PATCH bpf-next v4 1/9] tools: bpftool: add basic probe
 capability, probe syscall availability

On 01/17/2019 11:02 AM, Quentin Monnet wrote:
> 2019-01-16 16:28 UTC-0800 ~ Jakub Kicinski <jakub.kicinski@...ronome.com>
>> On Wed, 16 Jan 2019 14:21:11 +0000, Quentin Monnet wrote:
>>> +-------------------------------------------------------------------------------
>>> +tool for inspection of eBPF-related parameters for Linux kernel or net device
>>> +-------------------------------------------------------------------------------
>>
>> Slight preference for s/eBPF/BPF/, the system call and /proc/ stuff is
>> all called bpf, not ebpf.
>>
>> Also a question/nit here:
>>
>> Does the rst2man tool care about the marking vs text length, here
>> dashes are longer than the actual text, people are fixing such
>> occurrences for Sphinx, I wonder if we should care?
> 
> I'd rather keep it unchanged in this patch, as it is aligned with what other bpftool man pages do: bpftool, bpftool-cgroup, bpftool-map and bpftool-prog all have “eBPF” (bpftool-perf and bpftool-net have “bpf”, lower case) in their description. And all pages have longer dash rules, which rst2man does not seem to mind about.
> 
> I can fix all this for all bpftool pages in a follow-up patch, though, if it's alright for you?

My preference is on for s/eBPF/BPF/ as well, so lets fix everything up;
follow-up is okay with me.

Thanks,
Daniel