netdev - Re: [PATCH ipsec, resend 1/1] xfrm: Make set-mark default behavior backward compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190117113035.GO3581@gauss3.secunet.de>
Date:   Thu, 17 Jan 2019 12:30:35 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Benedict Wong <benedictwong@...gle.com>
CC:     <netdev@...r.kernel.org>, <tobias@...ongswan.org>,
        <eyal.birger@...il.com>, <lorenzo@...gle.com>,
        <nharold@...gle.com>, <maze@...gle.com>
Subject: Re: [PATCH ipsec, resend 1/1] xfrm: Make set-mark default behavior
 backward compatible

On Mon, Jan 14, 2019 at 11:24:38AM -0800, Benedict Wong wrote:
> Fixes 9b42c1f179a6, which changed the default route lookup behavior for
> tunnel mode SAs in the outbound direction to use the skb mark, whereas
> previously mark=0 was used if the output mark was unspecified. In
> mark-based routing schemes such as Android’s, this change in default
> behavior causes routing loops or lookup failures.
> 
> This patch restores the default behavior of using a 0 mark while still
> incorporating the skb mark if the SET_MARK (and SET_MARK_MASK) is
> specified.
> 
> Tested with additions to Android's kernel unit test suite:
> https://android-review.googlesource.com/c/kernel/tests/+/860150
> 
> Fixes: 9b42c1f179a6 ("xfrm: Extend the output_mark to support input direction and masking")
> Signed-off-by: Benedict Wong <benedictwong@...gle.com>

Applied, thanks a lot Benedict!