netdev - Re: [PATCH net 3/7] virtio_net: Fix not restoring real_num_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20c11700-f0a4-dbb8-1646-98da3b771d7f@redhat.com>
Date:   Thu, 17 Jan 2019 20:39:52 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Toshiaki Makita <makita.toshiaki@....ntt.co.jp>,
        "David S. Miller" <davem@...emloft.net>,
        "Michael S. Tsirkin" <mst@...hat.com>
Cc:     netdev@...r.kernel.org, virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH net 3/7] virtio_net: Fix not restoring real_num_rx_queues


On 2019/1/17 下午7:20, Toshiaki Makita wrote:
> When _virtnet_set_queues() failed we did not restore real_num_rx_queues.
> Fix this by placing the change of real_num_rx_queues after
> _virtnet_set_queues().
> This order is also in line with virtnet_set_channels().
>
> Fixes: 4941d472bf95 ("virtio-net: do not reset during XDP set")
> Signed-off-by: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
> ---
>   drivers/net/virtio_net.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 7d35e6d..670cc15 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -2427,10 +2427,10 @@ static int virtnet_xdp_set(struct net_device *dev, struct bpf_prog *prog,
>   		}
>   	}
>   
> -	netif_set_real_num_rx_queues(dev, curr_qp + xdp_qp);
>   	err = _virtnet_set_queues(vi, curr_qp + xdp_qp);
>   	if (err)
>   		goto err;
> +	netif_set_real_num_rx_queues(dev, curr_qp + xdp_qp);
>   	vi->xdp_queue_pairs = xdp_qp;
>   
>   	for (i = 0; i < vi->max_queue_pairs; i++) {


Acked-by: Jason Wang <jasowang@...hat.com>