netdev - Re: [PATCH] net: mlx5: update hw flows when encap source mac changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 17 Jan 2019 15:04:29 +0200
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     xiangxia.m.yue@...il.com
Cc:     Saeed Mahameed <saeedm@...lanox.com>,
        Leon Romanovsky <leonro@...lanox.com>,
        Linux Netdev List <netdev@...r.kernel.org>,
        Hadar Hen Zion <hadarh@...lanox.com>
Subject: Re: [PATCH] net: mlx5: update hw flows when encap source mac changed

On Fri, Jan 11, 2019 at 4:19 PM <xiangxia.m.yue@...il.com> wrote:
>
> From: Tonghao Zhang <xiangxia.m.yue@...il.com>

We have common prefix, please use it:

net/mlx5e: Update offloaded flows when encap source mac changed

> When we offload tc filters to hardware, hardware flows can
> be updated when mac of encap destination ip is changed.
> But we ignore one case, that the mac of local encap ip can
> be changed too, so we should also update them.
>
> To fix it, add route_dev in mlx5e_encap_entry struct to save
> the local encap netdevice, and when mac changed, check it and
> update flows.

The problem seems to exist and the solution seems to be proper

I will look into it later, please resend with [PATCH net-next]  and
few nit fixes

> Fixs: 232c00139 ("net/mlx5e: Add support to neighbour update flow")

should be Fixes: and get 12 hex digits (git log --oneline --abbrev=12)