netdev - Re: [PATCH] cw1200: fix indentation issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Jan 2019 14:56:23 +0000
From:   Colin Ian King <colin.king@...onical.com>
To:     Kalle Valo <kvalo@...eaurora.org>
Cc:     Solomon Peachy <pizza@...ftnet.org>,
        "David S . Miller" <davem@...emloft.net>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cw1200: fix indentation issues

On 17/01/2019 14:54, Kalle Valo wrote:
> Colin King <colin.king@...onical.com> writes:
> 
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> There are two lines that have indentation issues, fix these.
>>
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>> ---
>>  drivers/net/wireless/st/cw1200/fwio.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/st/cw1200/fwio.c b/drivers/net/wireless/st/cw1200/fwio.c
>> index 30e7646d04af..b7881232499c 100644
>> --- a/drivers/net/wireless/st/cw1200/fwio.c
>> +++ b/drivers/net/wireless/st/cw1200/fwio.c
>> @@ -465,8 +465,8 @@ int cw1200_load_firmware(struct cw1200_common *priv)
>>  
>>  	if (!(val32 & ST90TDS_CONFIG_ACCESS_MODE_BIT)) {
>>  		pr_err("Device is already in QUEUE mode!\n");
>> -			ret = -EINVAL;
>> -			goto out;
>> +		ret = -EINVAL;
>> +		goto out;
> 
> Just out of curiosity, how do you find these?
> 
smatch, grep for "warn: inconsistent indenting"

Colin