netdev - Re: [PATCH] bpf: Make function btf_name_offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <06e9a2f2-50f9-99af-9fe8-51dd5425fbb7@iogearbox.net>
Date:   Thu, 17 Jan 2019 16:56:53 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Martin Lau <kafai@...com>, Mathieu Malaterre <malat@...ian.org>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bpf: Make function btf_name_offset_valid static

On 01/16/2019 10:16 PM, Martin Lau wrote:
> On Wed, Jan 16, 2019 at 08:29:40PM +0100, Mathieu Malaterre wrote:
>> Initially in commit 69b693f0aefa ("bpf: btf: Introduce BPF Type Format
>> (BTF)") the function 'btf_name_offset_valid' was introduced as static
>> function it was later on changed to a non-static one, and then finally
>> in commit c454a46b5efd ("bpf: Add bpf_line_info support") the function
>> prototype was removed.
> Instead of c454a46b5efd, it was removed from btf.h in
> commit 23127b33ec80 ("bpf: Create a new btf_name_by_offset() for non type name use case")
> 
>>
>> Revert back to original implementation and make the function static.
>> Remove warning triggered with W=1:
>>
>>   kernel/bpf/btf.c:470:6: warning: no previous prototype for 'btf_name_offset_valid' [-Wmissing-prototypes]
>>
>> Signed-off-by: Mathieu Malaterre <malat@...ian.org>
> Fixes: 23127b33ec80 ("bpf: Create a new btf_name_by_offset() for non type name use case")
> 
> Thanks for the fix!
> 
> Other than the above,
> 
> Acked-by: Martin KaFai Lau <kafai@...com>

Applied to bpf and fixed up commit reference. Thanks!