netdev - Re: [PATCH bpf] bpf: fix panic in stack_map_get_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+G9fYvLdWoxrHALXAYJfA_5iixpu6QV=eNmxT-m+uDFSGH-UA@mail.gmail.com>
Date:   Thu, 17 Jan 2019 22:54:01 +0530
From:   Naresh Kamboju <naresh.kamboju@...aro.org>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     Song Liu <songliubraving@...com>, Netdev <netdev@...r.kernel.org>,
        kernel-team@...com, ast@...nel.org
Subject: Re: [PATCH bpf] bpf: fix panic in stack_map_get_build_id() on i386
 and arm32

On Thu, 10 Jan 2019 at 20:56, Daniel Borkmann <daniel@...earbox.net> wrote:
>
> On 01/08/2019 11:20 PM, Song Liu wrote:
> > As Naresh reported, test_stacktrace_build_id() causes panic on i386 and
> > arm32 systems. This is caused by page_address() returns NULL in certain
> > cases.
> >
> > This patch fixes this error by using kmap_atomic/kunmap_atomic instead
> > of page_address.
> >
> > Fixes: 615755a77b24 (" bpf: extend stackmap to save binary_build_id+offset instead of address")
> > Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> > Signed-off-by: Song Liu <songliubraving@...com>

Tested-by: Naresh Kamboju <naresh.kamboju@...aro.org>

>
> Looks correct to me, and in this case as per API the assumption is allowed
> that k[un]map_atomic() won't fail. I've applied it to bpf, if Naresh still
> replies with a Tested-by in time, I'll add it as well to the commit.

This patch fixes the problem on Linux kernel 5.0.0-rc2.
Thank you.

Best regards
Naresh Kamboju