lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 17 Jan 2019 13:36:06 -0500
From:   Vivien Didelot <>
To:     Florian Fainelli <>
Cc:, Florian Fainelli <>,,,,,,,,
Subject: Re: [PATCH net-next 12/14] net: dsa: Wire up multicast IGMP snooping
 attribute notification

On Wed, 16 Jan 2019 12:01:00 -0800, Florian Fainelli <> wrote:

> +	int	(*port_multicast_toggle)(struct dsa_switch *ds, int port,
> +					 bool mc_disabled);
Waw this looks counter-intuitive and error-prone... Would you prefer to make it
symmetrical to ops->port_vlan_filtering() by implementing ops->port_multicast()
and passing !obj->u.mc_disabled to it?



Powered by blists - more mailing lists