netdev - Re: [PATCH bpf] bpf: pull in pkt_sched.h header for tooling to fix bpftool build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190117192049.zq254sprs7g34pnx@kafai-mbp.dhcp.thefacebook.com>
Date:   Thu, 17 Jan 2019 19:20:51 +0000
From:   Martin Lau <kafai@...com>
To:     Daniel Borkmann <daniel@...earbox.net>
CC:     "ast@...nel.org" <ast@...nel.org>,
        "gilson@...oo.com" <gilson@...oo.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH bpf] bpf: pull in pkt_sched.h header for tooling to fix
 bpftool build

On Thu, Jan 17, 2019 at 04:15:09PM +0100, Daniel Borkmann wrote:
> Dan reported that bpftool does not compile for him:
> 
>   $ make tools/bpf
>     DESCEND  bpf
> 
>   Auto-detecting system features:
>   ..                        libbfd: [ on  ]
>   ..        disassembler-four-args: [ OFF ]
> 
>     DESCEND  bpftool
> 
>   Auto-detecting system features:
>   ..                        libbfd: [ on  ]
>   ..        disassembler-four-args: [ OFF ]
> 
>     CC       /opt/linux.git/tools/bpf/bpftool/net.o
>   In file included from /opt/linux.git/tools/include/uapi/linux/pkt_cls.h:6:0,
>                  from /opt/linux.git/tools/include/uapi/linux/tc_act/tc_bpf.h:14,
>                  from net.c:13:
>   net.c: In function 'show_dev_tc_bpf':
>   net.c:164:21: error: 'TC_H_CLSACT' undeclared (first use in this function)
>     handle = TC_H_MAKE(TC_H_CLSACT, TC_H_MIN_INGRESS);
>   [...]
> 
> Fix it by importing pkt_sched.h header copy into tooling
> infrastructure.
Acked-by: Martin KaFai Lau <kafai@...com>