netdev - RE: [PATCH net v3] net: bridge: Fix ethernet header pointer before check skb forwardable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <34EFBCA9F01B0748BEB6B629CE643AE60C9DDABB@DGGEMM533-MBX.china.huawei.com>
Date:   Thu, 17 Jan 2019 01:40:51 +0000
From:   wangyunjian <wangyunjian@...wei.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        xudingke <xudingke@...wei.com>,
        "bridge@...ts.linux-foundation.org" 
        <bridge@...ts.linux-foundation.org>,
        Nkolay Aleksandrov <nikolay@...ulusnetworks.com>,
        Roopa Prabhu <roopa@...ulusnetworks.com>
Subject: RE: [PATCH net v3] net: bridge: Fix ethernet header pointer before
 check skb forwardable

> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@...workplumber.org]
> Sent: Thursday, January 17, 2019 1:33 AM
> To: wangyunjian <wangyunjian@...wei.com>
> Cc: netdev@...r.kernel.org; xudingke <xudingke@...wei.com>;
> bridge@...ts.linux-foundation.org; Nkolay Aleksandrov
> <nikolay@...ulusnetworks.com>; Roopa Prabhu
> <roopa@...ulusnetworks.com>
> Subject: Re: [PATCH net v3] net: bridge: Fix ethernet header pointer before
> check skb forwardable
> 
> On Wed, 16 Jan 2019 21:04:21 +0800
> wangyunjian <wangyunjian@...wei.com> wrote:
> 
> >  		if (unlikely(netpoll_tx_running(to->br->dev))) {
> > +			skb_push(skb, ETH_HLEN);
> >  			if (!is_skb_forwardable(skb->dev, skb)) {
> >  				kfree_skb(skb);
> >  			} else {
> > -				skb_push(skb, ETH_HLEN);
> >  				br_netpoll_send_skb(to, skb);
> >  			}
> >  			return;
> 
> The patch looks correct.
> 
> On minor style issue is that after moving skb_push out of the if statement,
> both branches of the statement now contain a single line and therefore the
> brackets are no longer necessary.  Suprised that checkpatch did not complain
> about this.

OK, I'll fix it and send the v4 later.

Thanks
	Yunjian