netdev - Re: [PATCH] rtlwifi: rtl818x: fix indentation issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <284e7ef0-5820-021b-7b0c-2fc754440fe8@lwfinger.net>
Date:   Thu, 17 Jan 2019 13:33:53 -0600
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Joe Perches <joe@...ches.com>,
        Colin King <colin.king@...onical.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S . Miller" <davem@...emloft.net>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Ping-Ke Shih <pkshih@...ltek.com>
Subject: Re: [PATCH] rtlwifi: rtl818x: fix indentation issue

On 1/17/19 1:29 PM, Joe Perches wrote:
> On Thu, 2019-01-17 at 15:28 +0000, Colin King wrote:
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> There is a statement that is indented too deeply. Fix this.
> 
> Thanks.
> 
>> diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8180/dev.c b/drivers/net/wireless/realtek/rtl818x/rtl8180/dev.c
> []
>> @@ -803,7 +803,7 @@ static void rtl8180_config_cardbus(struct ieee80211_hw *dev)
>>   		rtl818x_iowrite16(priv, FEMR_SE, 0xffff);
>>   	} else {
>>   		reg16 = rtl818x_ioread16(priv, &priv->map->FEMR);
>> -			reg16 |= (1 << 15) | (1 << 14) | (1 << 4);
>> +		reg16 |= (1 << 15) | (1 << 14) | (1 << 4);
>>   		rtl818x_iowrite16(priv, &priv->map->FEMR, reg16);
>>   	}
> 
> trivia:
> 
> It sure looks as if there could be some rather useful
> conversions of magic bits to constants one day.

How much work is warranted for this driver for a device that is not likely in 
use anywhere in the wild? In addition, I'm not sure anyone knows what those bits 
actually do, I certainly do not have a product sheet for that one.

Larry