netdev - Re: [PATCH v2 net-next] net: phy: check return code when requesting PHY driver module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190117.115730.116895184803079318.davem@davemloft.net>
Date:   Thu, 17 Jan 2019 11:57:30 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] net: phy: check return code when
 requesting PHY driver module

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Wed, 16 Jan 2019 08:07:38 +0100

> When requesting the PHY driver module fails we'll bind the genphy
> driver later. This isn't obvious to the user and may cause, depending
> on the PHY, different types of issues. Therefore check the return code
> of request_module(). Note that we only check for failures in loading
> the module, not whether a module exists for the respective PHY ID.
> 
> v2:
> - add comment explaining what is checked and what is not
> - return error from phy_device_create() if loading module fails
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied, thanks Heiner.