netdev - Re: [PATCH net v2] net/sched: cls_flower: allocate mask dynamically in fl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190117.144152.329245934020352870.davem@davemloft.net>
Date:   Thu, 17 Jan 2019 14:41:52 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     ivecera@...hat.com
Cc:     netdev@...r.kernel.org, poros@...hat.com, jiri@...nulli.us,
        paulb@...lanox.com
Subject: Re: [PATCH net v2] net/sched: cls_flower: allocate mask
 dynamically in fl_change()

From: Ivan Vecera <ivecera@...hat.com>
Date: Wed, 16 Jan 2019 16:53:52 +0100

> Recent changes (especially 05cd271fd61a ("cls_flower: Support multiple
> masks per priority")) in the fl_flow_mask structure grow it and its
> current size e.g. on x86_64 with defconfig is 760 bytes and more than
> 1024 bytes with some debug options enabled. Prior the mentioned commit
> its size was 176 bytes (using defconfig on x86_64).
> With regard to this fact it's reasonable to allocate this structure
> dynamically in fl_change() to reduce its stack size.
> 
> v2:
> - use kzalloc() instead of kcalloc()
> 
> Fixes: 05cd271fd61a ("cls_flower: Support multiple masks per priority")
> Cc: Jiri Pirko <jiri@...nulli.us>
> Cc: Paul Blakey <paulb@...lanox.com>
> Acked-by: Jiri Pirko <jiri@...lanox.com>
> Signed-off-by: Ivan Vecera <ivecera@...hat.com>

Applied and queued up for -stable.