netdev - Re: [PATCH net-next 00/11] tcp: remove code from tcp_create_openreq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACSApvbyPLRCu_bgJOwJgO6NR0_-F66oAQGnE7eVdidB5=kOKA@mail.gmail.com>
Date:   Thu, 17 Jan 2019 17:42:58 -0500
From:   Soheil Hassas Yeganeh <soheil@...gle.com>
To:     Yuchung Cheng <ycheng@...gle.com>
Cc:     Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Neal Cardwell <ncardwell@...gle.com>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH net-next 00/11] tcp: remove code from tcp_create_openreq_child()

On Thu, Jan 17, 2019 at 5:20 PM Yuchung Cheng <ycheng@...gle.com> wrote:
>
> On Thu, Jan 17, 2019 at 11:23 AM Eric Dumazet <edumazet@...gle.com> wrote:
> >
> > tcp_create_openreq_child() is essentially cloning a listener, then
> > must initialize some fields that can not be inherited.
> >
> > Listeners are either fresh sockets, or sockets that came through
> > tcp_disconnect() after a session that dirtied many fields.
> >
> > By moving code to tcp_disconnect(), we can shorten time taken
> > to create a clone, since tcp_disconnect() operation is very
> > unlikely.
> >
> > Eric Dumazet (11):
> >   tcp: do not set snd_ssthresh in tcp_create_openreq_child()
> >   tcp: move icsk_rto init to tcp_disconnect()
> >   tcp: do not clear packets_out in tcp_create_openreq_child()
> >   tcp: do not clear srtt_us in tcp_create_openreq_child
> >   tcp: move mdev_us init to tcp_disconnect()
> >   tcp: move snd_cwnd & snd_cwnd_cnt init to tcp_disconnect()
> >   tcp: do not clear urg_data in tcp_create_openreq_child
> >   tcp: move retrans_out,sacked_out,tlp_high_seq,last_oow_ack_time init
> >     to tcp_disconnect()
> >   tcp: move app_limited init to tcp_disconnect()
> >   tcp: move tp->rack init to tcp_disconnect()
> >   tcp: move rx_opt & syn_data_acked init to tcp_disconnect()
> >
> >  net/ipv4/tcp.c           | 21 ++++++++++++++++++++-
> >  net/ipv4/tcp_minisocks.c | 34 ----------------------------------
> >  2 files changed, 20 insertions(+), 35 deletions(-)
> >
> > --
> Entire patch set looks great to me!
>
> Acked-by: Yuchung Cheng <ycheng@...gle.com>

Acked-by: Soheil Hassas Yeganeh <soheil@...gle.com>

Thank you very much, Eric, for the nice code removal!

> > 2.20.1.321.g9e740568ce-goog
> >