netdev - Re: [PATCH net-next] dpaa2-eth: Fix ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190117.153826.1892826631087233312.davem@davemloft.net>
Date:   Thu, 17 Jan 2019 15:38:26 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     ruxandra.radulescu@....com
Cc:     netdev@...r.kernel.org, ioana.ciornei@....com
Subject: Re: [PATCH net-next] dpaa2-eth: Fix ndo_stop routine

From: Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>
Date: Wed, 16 Jan 2019 16:51:44 +0000

> In the current implementation, on interface down we disabled NAPI and
> then manually drained any remaining ingress frames. This could lead
> to a situation when, under heavy traffic, the data availability
> notification for some of the channels would not get rearmed correctly.
> 
> Change the implementation such that we let all remaining ingress frames
> be processed as usual and only disable NAPI once the hardware queues
> are empty.
> 
> We also add a wait on the Tx side, to allow hardware time to process
> all in-flight Tx frames before issueing the disable command.
> 
> Signed-off-by: Ioana Radulescu <ruxandra.radulescu@....com>

Applied.