[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6faa5289-c086-ac5e-33e5-ee144359ccf6@netronome.com>
Date: Thu, 17 Jan 2019 10:02:37 +0000
From: Quentin Monnet <quentin.monnet@...ronome.com>
To: Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc: Alexei Starovoitov <ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org,
oss-drivers@...ronome.com,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Jesper Dangaard Brouer <brouer@...hat.com>,
Stanislav Fomichev <sdf@...gle.com>
Subject: Re: [PATCH bpf-next v4 1/9] tools: bpftool: add basic probe
capability, probe syscall availability
2019-01-16 16:28 UTC-0800 ~ Jakub Kicinski <jakub.kicinski@...ronome.com>
> On Wed, 16 Jan 2019 14:21:11 +0000, Quentin Monnet wrote:
>> +-------------------------------------------------------------------------------
>> +tool for inspection of eBPF-related parameters for Linux kernel or net device
>> +-------------------------------------------------------------------------------
>
> Slight preference for s/eBPF/BPF/, the system call and /proc/ stuff is
> all called bpf, not ebpf.
>
> Also a question/nit here:
>
> Does the rst2man tool care about the marking vs text length, here
> dashes are longer than the actual text, people are fixing such
> occurrences for Sphinx, I wonder if we should care?
>
I'd rather keep it unchanged in this patch, as it is aligned with what
other bpftool man pages do: bpftool, bpftool-cgroup, bpftool-map and
bpftool-prog all have “eBPF” (bpftool-perf and bpftool-net have “bpf”,
lower case) in their description. And all pages have longer dash rules,
which rst2man does not seem to mind about.
I can fix all this for all bpftool pages in a follow-up patch, though,
if it's alright for you?
Quentin
Powered by blists - more mailing lists