netdev - Re: [PATCH net-next 06/13] net: namespace: perform strict checks also for doit handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72291d06-f985-8a02-75b1-8f2507cdb3ce@6wind.com>
Date:   Fri, 18 Jan 2019 09:17:46 +0100
From:   Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>, davem@...emloft.net,
        dsahern@...il.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        ktkhai@...tuozzo.com
Subject: Re: [PATCH net-next 06/13] net: namespace: perform strict checks also
 for doit handlers

Le 17/01/2019 à 23:52, Jakub Kicinski a écrit :
> Make RTM_GETNSID's doit handler use strict checks when
> NETLINK_F_STRICT_CHK is set.
> 
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> ---
> CC: ktkhai@...tuozzo.com
> CC: nicolas.dichtel@...nd.com
> ---
>  net/core/net_namespace.c | 43 ++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 41 insertions(+), 2 deletions(-)
> 
> diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c
> index b02fb19df2cc..1b45e3ab2b65 100644
> --- a/net/core/net_namespace.c
> +++ b/net/core/net_namespace.c
> @@ -778,6 +778,46 @@ static int rtnl_net_fill(struct sk_buff *skb, struct net_fill_args *args)
>  	return -EMSGSIZE;
>  }
>  
> +static int rtnl_net_valid_getid_req(struct sk_buff *skb,
> +				    const struct nlmsghdr *nlh,
> +				    struct nlattr **tb,
> +				    struct netlink_ext_ack *extack)
> +{
> +	int i, err;
> +
> +	if (nlh->nlmsg_len < nlmsg_msg_size(sizeof(struct rtgenmsg))) {
This is not possible, the check is already done in rtnetlink_rcv_msg().


Regards,
Nicolas