netdev - Re: [Patch net v2] mlx5: fixup checksum for short ethernet frame padding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALMXkpa6GkMhVw+BbC0gNYXRSa9_r-p1AnW+upvWZSqvpRvMaQ@mail.gmail.com>
Date:   Thu, 17 Jan 2019 17:19:11 -0800
From:   Christoph Paasch <christoph.paasch@...il.com>
To:     Saeed Mahameed <saeedm@....mellanox.co.il>
Cc:     Nikola Ciprich <nikola.ciprich@...uxbox.cz>,
        Saeed Mahameed <saeedm@...lanox.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>
Subject: Re: [Patch net v2] mlx5: fixup checksum for short ethernet frame padding

Hello,

On Sun, Jan 6, 2019 at 3:12 AM Saeed Mahameed <saeedm@....mellanox.co.il> wrote:
>
> On Sat, Jan 5, 2019 at 8:35 PM Nikola Ciprich
> <nikola.ciprich@...uxbox.cz> wrote:
> >
> > Hi Saeed,
> >
> >
> > > Most likely the same issue, we are finalizing the patch initially
> > > proposed by Cong, you can find it here, I plan to submit it next week,
> > > after all the regression tests.
> > >
> > > https://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git/commit/?h=topic/csum-fix
> > >
> > > It would be nice if you verify this fixes your issue.
> >
> > I tried 4.20.0 + this fix and the problems are gone! haven't done backport to 4.19 yet.
> >
> > cheers!
>
> Thanks nik for your input, we will submit a similar fix very soon.

We are also seeing similar issues on v4.14.94, as Eric's patch got
backported with 6bf32cda46eb.

I backported (had to do some changes to solve the conflicts) your fix
from topic/csum-fix to v4.14.94, but then I still get the warning when
the frame is bigger than ETH_ZLEN (which is quite unsurprising ;-)).
Eric already pointed that out that one can cook bigger frames with
padding (cfr., https://patchwork.ozlabs.org/patch/1004117/).

What is the plan to get rid of the warning in v4.14-stable?


Thanks,
Christoph



>
> >
> > nik
> >
> >
> >
> > >
> > > Thanks,
> > > Saeed.
> > >
> > >
> > > > thanks a lot in advance
> > > >
> > > > BR
> > > >
> > > > nik
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > >
> > > > > Thanks,
> > > > > Saeed.
> > > > >
> > >
> >
> > --
> > -------------------------------------
> > Ing. Nikola CIPRICH
> > LinuxBox.cz, s.r.o.
> > 28. rijna 168, 709 00 Ostrava
> >
> > tel.:   +420 591 166 214
> > fax:    +420 596 621 273
> > mobil:  +420 777 093 799
> >
> > www.linuxbox.cz
> >
> > mobil servis: +420 737 238 656
> > email servis: servis@...uxbox.cz
> > -------------------------------------