netdev - Re: [PATCH] net: mlx5: allow default ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ3xEMgcU_MJRnGk46AhM2Xr82gTKRgET4NJicDkeDdj5h7nNA@mail.gmail.com>
Date:   Fri, 18 Jan 2019 16:19:05 +0200
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     Tonghao Zhang <xiangxia.m.yue@...il.com>
Cc:     Or Gerlitz <ogerlitz@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Leon Romanovsky <leonro@...lanox.com>,
        Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: mlx5: allow default ip_proto to offload

On Thu, Jan 17, 2019 at 3:34 PM Tonghao Zhang <xiangxia.m.yue@...il.com> wrote:
> On Thu, Jan 17, 2019 at 8:58 PM Or Gerlitz <gerlitz.or@...il.com> wrote:
> > On Thu, Jan 17, 2019 at 11:28 AM <xiangxia.m.yue@...il.com> wrote:
> > > From: Tonghao Zhang <xiangxia.m.yue@...il.com>

> with this patch, run the command [2], we will not get err log,
> and the filter work in hw.

This whole thing is done for a reason which is the inability of the current HW
to adjust checksum/crc for few L3 protocols. Such adjustment is needed if
you modify some fields of L3 headers, e.g re-write src/dst IP address.

> We should consider ip_proto == 0, in some case, we only
> modify dest ip or src ip.

we can't let it go without clear matching on the ip protocol, as I explained
above. With my proposed patch you will be able to NAT much more protocols
(all of them expect for three, and we're working to reduce that), but
you still need
a tc rule per ip proto