netdev - Re: [PATCH net-next] net: usb: rtl8150: remove set but not used variable 'rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190118143021.GJ29272@p310>
Date:   Fri, 18 Jan 2019 16:30:21 +0200
From:   Petko Manolov <petkan@...leusys.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     "David S. Miller" <davem@...emloft.net>, linux-usb@...r.kernel.org,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: usb: rtl8150: remove set but not used
 variable 'rx_stat'

On 19-01-18 02:06:49, YueHaibing wrote:
> From: Yue Haibing <yuehaibing@...wei.com>
> 
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/usb/rtl8150.c: In function 'read_bulk_callback':
> drivers/net/usb/rtl8150.c:391:6: warning:
>  variable 'rx_stat' set but not used [-Wunused-but-set-variable]

Good catch, thanks.


		Petko


> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
> ---
>  drivers/net/usb/rtl8150.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
> index 80373a9..3f145e4 100644
> --- a/drivers/net/usb/rtl8150.c
> +++ b/drivers/net/usb/rtl8150.c
> @@ -388,7 +388,6 @@ static void read_bulk_callback(struct urb *urb)
>  	unsigned pkt_len, res;
>  	struct sk_buff *skb;
>  	struct net_device *netdev;
> -	u16 rx_stat;
>  	int status = urb->status;
>  	int result;
>  	unsigned long flags;
> @@ -424,7 +423,6 @@ static void read_bulk_callback(struct urb *urb)
>  		goto goon;
>  
>  	res = urb->actual_length;
> -	rx_stat = le16_to_cpu(*(__le16 *)(urb->transfer_buffer + res - 4));
>  	pkt_len = res - 4;
>  
>  	skb_put(dev->rx_skb, pkt_len);
> 
> 
> 
>