netdev - Re: [PATCH ethtool] ethtool: don't report UFO on kernels v4.14 and above

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190118183913.GB30266@tuxdriver.com>
Date:   Fri, 18 Jan 2019 13:39:13 -0500
From:   "John W. Linville" <linville@...driver.com>
To:     Ivan Vecera <cera@...a.cz>
Cc:     netdev@...r.kernel.org, "John W . Linville" <linville@...hat.com>
Subject: Re: [PATCH ethtool] ethtool: don't report UFO on kernels v4.14 and
 above

On Thu, Nov 29, 2018 at 04:36:53PM +0100, Ivan Vecera wrote:
> Support for UDP fragmentation offloading was removed in kernel v4.14.
> The ethtool reports incorrectly its state on this and newer kernels:
> 
> $ ethtool -k enp0s31f6 | grep udp-frag
> udp-fragmentation-offload: off
> 
> It's look like that the feature is supported and disabled only. Instead
> of this behavior the status of UFO should not be reported on such kernels.
> 
> As the UFO is only one feature that was removed from the ethtool I have
> decided after discussion with John to implement only simple check for
> this instead of implementing more generic solution like 'max_kernel_ver
> field in struct off_flag_def'.
> 
> Cc: John W. Linville <linville@...hat.com>
> Signed-off-by: Ivan Vecera <cera@...a.cz>

Queued for next release.

-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.