netdev - Re: [PATCH] net: Fix usage of pskb_trim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190118.140536.1289771503734412771.davem@davemloft.net>
Date:   Fri, 18 Jan 2019 14:05:36 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     ross.lagerwall@...rix.com
Cc:     netdev@...r.kernel.org, mostrows@...thlink.net,
        pablo@...filter.org, kadlec@...ckhole.kfki.hu, fw@...len.de,
        roopa@...ulusnetworks.com, nikolay@...ulusnetworks.com,
        kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH] net: Fix usage of pskb_trim_rcsum

From: Ross Lagerwall <ross.lagerwall@...rix.com>
Date: Thu, 17 Jan 2019 15:34:38 +0000

> In certain cases, pskb_trim_rcsum() may change skb pointers.
> Reinitialize header pointers afterwards to avoid potential
> use-after-frees. Add a note in the documentation of
> pskb_trim_rcsum(). Found by KASAN.
> 
> Signed-off-by: Ross Lagerwall <ross.lagerwall@...rix.com>

Applied and queued up for -stable.