netdev - DSA incompatible with TI CPSW device model in dual mac mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <15e21356-0301-62c8-7d8f-0ea9680331f5@orlandi.com>
Date:   Sat, 19 Jan 2019 00:09:39 +0100
From:   Daniele Orlandi <daniele@...andi.com>
To:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: DSA incompatible with TI CPSW device model in dual mac mode

Hello,

I am trying to connect a Marvell switch (88E6172) to an AM3352 ethernet 
port.

In the DSA devicetree description the CPU port has to have an "ethernet" 
  attribute with a reference to a device node. From which it derives the 
net_device with a call of of_find_net_device_by_node

The CPSW driver, however, has a single device node with multiple (two) 
net_devices associated.

Thus, if I reference the "mac" (ethernet@...00000) node the first (eth0) 
port is matched.

There is no way to actually reference eth1.

I patched dsa2.c to also support a "ethernet-name" attribute which 
references to the device by name but it is super ugly...

Any idea an what could be the best approach for such scenarios?

Thanks,
Regards,

-- 
   Daniele Orlandi

Download attachment "smime.p7s" of type "application/pkcs7-signature" (3994 bytes)