netdev - Re: [PATCH] amd-xgbe: Fix mdio access for non-zero ports and clause 45 PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190117.220709.449114914088828096.davem@davemloft.net>
Date:   Thu, 17 Jan 2019 22:07:09 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     Thomas.Lendacky@....com
Cc:     netdev@...r.kernel.org, Shyam-sundar.S-k@....com
Subject: Re: [PATCH] amd-xgbe: Fix mdio access for non-zero ports and
 clause 45 PHYs

From: "Lendacky, Thomas" <Thomas.Lendacky@....com>
Date: Thu, 17 Jan 2019 14:20:14 +0000

> The XGBE hardware has support for performing MDIO operations using an
> MDIO command request. The driver mistakenly uses the mdio port address
> as the MDIO command request device address instead of the MDIO command
> request port address. Additionally, the driver does not properly check
> for and create a clause 45 MDIO command.
> 
> Check the supplied MDIO register to determine if the request is a clause
> 45 operation (MII_ADDR_C45). For a clause 45 operation, extract the device
> address and register number from the supplied MDIO register and use them
> to set the MDIO command request device address and register number fields.
> For a clause 22 operation, the MDIO request device address is set to zero
> and the MDIO command request register number is set to the supplied MDIO
> register. In either case, the supplied MDIO port address is used as the
> MDIO command request port address.
> 
> Fixes: 732f2ab7afb9 ("amd-xgbe: Add support for MDIO attached PHYs")
> Signed-off-by: Tom Lendacky <thomas.lendacky@....com>
> ---
> 
> Please queue this patch up for stable, 4.14 and higher.

Applied and queued up for -stable.