netdev - Re: [PATCH net-next 0/4] net: phy: improve starting PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B87B14D2-B0B3-4DFA-9D25-6F48D378C14A@gmail.com>
Date:   Sat, 19 Jan 2019 15:44:54 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Heiner Kallweit <hkallweit1@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 0/4] net: phy: improve starting PHY

Hi Heiner,

On January 19, 2019 3:27:29 AM PST, Heiner Kallweit <hkallweit1@...il.com> wrote:
>This patch series improves few aspects of starting the PHY.

This looks good as usual, just one minor comment in patch 4. Thanks!

>
>Heiner Kallweit (4):
>  net: phy: start state machine in phy_start only
>  net: phy: warn if phy_start is called from invalid state
>  net: phy: start interrupts in phy_start
>  net: phy: change phy_start_interrupts to phy_request_interrupt
>
> drivers/net/phy/phy.c        | 52 +++++++++++++++++-------------------
> drivers/net/phy/phy_device.c |  5 ++--
> drivers/net/phy/phylink.c    |  5 ++--
> include/linux/phy.h          |  2 +-
> 4 files changed, 29 insertions(+), 35 deletions(-)

-- 
Florian