netdev - RE: [PATCH hyperv-fixes,3/3] Fix hash key value reset after other ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CY4PR21MB0773301A98C99B1CEDF16C3DD79D0@CY4PR21MB0773.namprd21.prod.outlook.com>
Date:   Sat, 19 Jan 2019 01:14:25 +0000
From:   Michael Kelley <mikelley@...rosoft.com>
To:     Haiyang Zhang <haiyangz@...rosoft.com>,
        "sashal@...nel.org" <sashal@...nel.org>
CC:     KY Srinivasan <kys@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "olaf@...fle.de" <olaf@...fle.de>, vkuznets <vkuznets@...hat.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH hyperv-fixes,3/3] Fix hash key value reset after other ops

From: Haiyang Zhang <haiyangz@...rosoft.com> Sent: Monday, January 14, 2019 4:52 PM
> 
> Changing mtu, channels, or buffer sizes ops call to netvsc_attach(),
> rndis_set_subchannel(), which always reset the hash key to default
> value. That will override hash key changed previously. This patch
> fixes the problem by save the hash key, then restore it when we re-
> add the netvsc device.
> 
> Fixes: ff4a44199012 ("netvsc: allow get/set of RSS indirection table")
> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> ---
>  drivers/net/hyperv/hyperv_net.h   | 10 +++++++---
>  drivers/net/hyperv/netvsc.c       |  2 +-
>  drivers/net/hyperv/netvsc_drv.c   |  5 ++++-
>  drivers/net/hyperv/rndis_filter.c |  9 +++++++--
>  4 files changed, 19 insertions(+), 7 deletions(-)
> 
Reviewed-by: Michael Kelley <mikelley@...rosoft.com>