netdev - Re: [PATCH net-next] virtio-net: per-queue RPS config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190119.100557.1528610083215278910.davem@davemloft.net>
Date:   Sat, 19 Jan 2019 10:05:57 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     willemdebruijn.kernel@...il.com
Cc:     netdev@...r.kernel.org, mst@...hat.com, jasowang@...hat.com,
        willemb@...gle.com, mhlady@...gle.com
Subject: Re: [PATCH net-next] virtio-net: per-queue RPS config

From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Date: Thu, 17 Jan 2019 20:08:53 -0500

> From: Willem de Bruijn <willemb@...gle.com>
> 
> On multiqueue network devices, RPS maps are configured independently
> for each receive queue through /sys/class/net/$DEV/queues/rx-*.
> 
> On virtio-net currently all packets use the map from rx-0, because the
> real rx queue is not known at time of map lookup by get_rps_cpu.
> 
> Call skb_record_rx_queue in the driver rx path to make lookup work.
> 
> Recording the receive queue has ramifications beyond RPS, such as in
> sticky load balancing decisions for sockets (skb_tx_hash) and XPS.
> 
> Reported-by: Mark Hlady <mhlady@...gle.com>
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Applied, thanks Willem.