netdev - Re: [PATCH 5/8] Bluetooth: btrtl: add support for the RTL8723CS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201901212229.LRC8T5VA%fengguang.wu@intel.com>
Date:   Mon, 21 Jan 2019 22:31:34 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Vasily Khoruzhick <anarsoul@...il.com>
Cc:     kbuild-all@...org, "David S. Miller" <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Maxime Ripard <maxime.ripard@...tlin.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Vasily Khoruzhick <anarsoul@...il.com>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-bluetooth@...r.kernel.org
Subject: Re: [PATCH 5/8] Bluetooth: btrtl: add support for the RTL8723CS

Hi Vasily,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bluetooth-next/master]
[also build test ERROR on v5.0-rc2 next-20190116]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Vasily-Khoruzhick/Add-support-for-rtl8723bs-rtl8723cs-bluetooth/20190121-190321
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: x86_64-randconfig-x016-201903 (attached as .config)
compiler: gcc-8 (Debian 8.2.0-14) 8.2.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

   In file included from drivers/bluetooth/btusb.c:39:
   drivers/bluetooth/btrtl.h: In function 'btrtl_get_uart_settings':
>> drivers/bluetooth/btrtl.h:111:20: error: invalid storage class for function 'btrtl_apply_quirks'
    static inline void btrtl_apply_quirks(struct hci_dev *hdev,
                       ^~~~~~~~~~~~~~~~~~
>> drivers/bluetooth/btrtl.h:111:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
    static inline void btrtl_apply_quirks(struct hci_dev *hdev,
    ^~~~~~

vim +/btrtl_apply_quirks +111 drivers/bluetooth/btrtl.h

   102	
   103	static inline int btrtl_get_uart_settings(struct hci_dev *hdev,
   104						  struct btrtl_device_info *btrtl_dev,
   105						  unsigned int *controller_baudrate,
   106						  u32 *device_baudrate,
   107						  bool *flow_control)
   108	{
   109		return -ENOENT;
   110	
 > 111	static inline void btrtl_apply_quirks(struct hci_dev *hdev,
   112				struct btrtl_device_info *btrtl_dev)
   113	{
   114	}
   115	}
   116	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (29859 bytes)