netdev - Re: [PATCH] net: fec: get regulator optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1e9d19d78fb41480b21aadc7f273dca12f7472a.camel@toradex.com>
Date:   Mon, 21 Jan 2019 15:37:11 +0000
From:   Marcel Ziswiler <marcel.ziswiler@...adex.com>
To:     "stefan@...er.ch" <stefan@...er.ch>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "fugang.duan@....com" <fugang.duan@....com>
CC:     Max Krummenacher <max.krummenacher@...adex.com>,
        "dev@...henker.ch" <dev@...henker.ch>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: fec: get regulator optional

On Mon, 2019-01-21 at 15:58 +0100, Stefan Agner wrote:
> According to the device tree binding the phy-supply property is
> optional. Use the regulator_get_optional API accordingly. The
> code already handles NULL just fine.
> 
> This gets rid of the following warning:
>   fec 2188000.ethernet: 2188000.ethernet supply phy not found, using
> dummy regulator
> 
> Signed-off-by: Stefan Agner <stefan@...er.ch>

Reviewed-by: Marcel Ziswiler <marcel.ziswiler@...adex.com>

> ---
>  drivers/net/ethernet/freescale/fec_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index 6db69ba30dcd..c8315d880c8c 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -3479,7 +3479,7 @@ fec_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto failed_clk_ipg;
>  
> -	fep->reg_phy = devm_regulator_get(&pdev->dev, "phy");
> +	fep->reg_phy = devm_regulator_get_optional(&pdev->dev, "phy");
>  	if (!IS_ERR(fep->reg_phy)) {
>  		ret = regulator_enable(fep->reg_phy);
>  		if (ret) {